From aed0800aac98e37ddc029765c1d23332a0c11824 Mon Sep 17 00:00:00 2001 From: lupoDharkael Date: Wed, 12 Jul 2017 02:06:08 +0200 Subject: [PATCH 1/4] Delete all mouse-visibility references --- src/capture/button.cpp | 19 ------------------- src/capture/button.h | 3 --- src/capture/capturewidget.cpp | 1 - src/capture/screenshot.cpp | 4 ---- src/controller.cpp | 1 - 5 files changed, 28 deletions(-) diff --git a/src/capture/button.cpp b/src/capture/button.cpp index d955fdb3..6ff7231b 100644 --- a/src/capture/button.cpp +++ b/src/capture/button.cpp @@ -80,17 +80,6 @@ QIcon Button::getIcon(const Type t, bool isWhite) { } QString path = ":/img/buttonIcons" + iconColor + "/"; -// if (t == Type::mouseVisibility) { -// QSettings settings; -// bool mouseVisible = settings.value("mouseVisible").toBool(); -// if (mouseVisible){ -// path += "mouse.svg"; -// } else { -// path += "mouse-off.svg"; -// } -// return QIcon(path); -// } - switch (t) { case Type::arrow: path += "arrow-bottom-left.png"; @@ -190,14 +179,6 @@ void Button::mouseReleaseEvent(QMouseEvent *e) { CaptureWidget *parent = static_cast(this->parent()); parent->mouseReleaseEvent(e); if (e->button() == Qt::LeftButton && m_pressed) { -// if (m_buttonType == Type::mouseVisibility) { -// QSettings settings; -// bool mouseVisible = settings.value("mouseVisible").toBool(); -// settings.setValue("mouseVisible", !mouseVisible); -// setIcon(getIcon(Type::mouseVisibility)); -// } else if (m_buttonType == Type::colorPicker) { - -// } Q_EMIT pressedButton(this); } m_pressed = false; diff --git a/src/capture/button.h b/src/capture/button.h index bdd74339..733790c1 100644 --- a/src/capture/button.h +++ b/src/capture/button.h @@ -45,9 +45,6 @@ public: exit, imageUploader, last, // used for iteration over the enum - text, - mouseVisibility, - colorPicker }; explicit Button(const Type, QWidget *parent = 0); diff --git a/src/capture/capturewidget.cpp b/src/capture/capturewidget.cpp index 45340b0f..d28fbb07 100644 --- a/src/capture/capturewidget.cpp +++ b/src/capture/capturewidget.cpp @@ -522,7 +522,6 @@ void CaptureWidget::downResize() { void CaptureWidget::setState(Button *b) { Button::Type t = b->getButtonType(); if(t == Button::Type::selectionIndicator || - //t == Button::Type::mouseVisibility || t == Button::Type::colorPicker) { return; } diff --git a/src/capture/screenshot.cpp b/src/capture/screenshot.cpp index d34b5f3a..af826605 100644 --- a/src/capture/screenshot.cpp +++ b/src/capture/screenshot.cpp @@ -118,9 +118,6 @@ QString Screenshot::graphicalSave(const QRect &selection, QWidget *parent) const } else { // save full screen when no selection pixToSave = m_modifiedScreenshot.copy(selection); } -// if (settings.value("mouseVisible").toBool()) { -// // TO DO -// } saved = pixToSave.save(fileName); if (!saved) { @@ -215,7 +212,6 @@ namespace { int originalLength = body.length(); body.setLength(ArrowWidth); // move across the line up to the head - //QPointF = ; QLineF temp(QPoint(0,0), p2-p1); temp.setLength(originalLength-ArrowHeight); QPointF bottonTranslation(temp.p2()); diff --git a/src/controller.cpp b/src/controller.cpp index 8666123d..127ffcdb 100644 --- a/src/controller.cpp +++ b/src/controller.cpp @@ -97,7 +97,6 @@ void Controller::initDefaults() { settings.setValue("showHelp", true); settings.setValue("showDesktopNotification", true); settings.setValue("drawColor", QColor(Qt::red)); - //settings.setValue("mouseVisible", false); settings.setValue("uiColor", QColor(116, 0, 150)); settings.setValue("contastUiColor", QColor(86, 0, 120)); From 83e6a5d53dcacef900a30a0d649868d1843aabf4 Mon Sep 17 00:00:00 2001 From: lupoDharkael Date: Wed, 12 Jul 2017 11:20:36 +0200 Subject: [PATCH 2/4] Update qsettings info --- docs/dev/qsettings.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/dev/qsettings.md b/docs/dev/qsettings.md index 02a5b5ca..50b89a6f 100644 --- a/docs/dev/qsettings.md +++ b/docs/dev/qsettings.md @@ -10,10 +10,6 @@ - value: "drawColor" - type: QColor - description: color of the drawing tools. -- Mouse visibility - - value: "mouseVisible" - - type: bool - - description: visibility of the mouse in the capture. - UI color - value: "uiColor" - type: QColor From 9357312855f3dce4f102b31833b399c208cf1bc8 Mon Sep 17 00:00:00 2001 From: lupoDharkael Date: Wed, 12 Jul 2017 15:41:36 +0200 Subject: [PATCH 3/4] Remove unsupported tools --- flameshot.pro | 10 +- img/buttonIconsBlack/format-text.png | Bin 254 -> 0 bytes img/buttonIconsBlack/mouse-off.png | Bin 387 -> 0 bytes img/buttonIconsBlack/mouse.png | Bin 336 -> 0 bytes img/buttonIconsWhite/mouse-off.png | Bin 394 -> 0 bytes img/buttonIconsWhite/mouse.png | Bin 340 -> 0 bytes src/capture/buttonhandler.cpp | 26 ++-- src/capture/buttonhandler.h | 10 +- src/capture/{button.cpp => capturebutton.cpp} | 124 ++++++++---------- src/capture/{button.h => capturebutton.h} | 18 +-- src/capture/capturemodification.cpp | 28 ++-- src/capture/capturemodification.h | 8 +- src/capture/capturewidget.cpp | 65 +++++---- src/capture/capturewidget.h | 12 +- src/capture/screenshot.cpp | 18 +-- src/capture/tools/capturetool.cpp | 6 + src/capture/tools/capturetool.h | 26 ++++ src/config/buttonlistview.cpp | 14 +- src/config/configwindow.cpp | 2 +- src/config/uicoloreditor.cpp | 18 +-- src/config/uicoloreditor.h | 14 +- src/controller.cpp | 8 +- 22 files changed, 214 insertions(+), 193 deletions(-) delete mode 100644 img/buttonIconsBlack/format-text.png delete mode 100644 img/buttonIconsBlack/mouse-off.png delete mode 100644 img/buttonIconsBlack/mouse.png delete mode 100644 img/buttonIconsWhite/mouse-off.png delete mode 100644 img/buttonIconsWhite/mouse.png rename src/capture/{button.cpp => capturebutton.cpp} (60%) rename src/capture/{button.h => capturebutton.h} (81%) create mode 100644 src/capture/tools/capturetool.cpp create mode 100644 src/capture/tools/capturetool.h diff --git a/flameshot.pro b/flameshot.pro index 70f15b6a..3638eddf 100644 --- a/flameshot.pro +++ b/flameshot.pro @@ -37,7 +37,6 @@ DEFINES += QAPPLICATION_CLASS=QApplication SOURCES += src/main.cpp\ src/controller.cpp \ - src/capture/button.cpp \ src/capture/buttonhandler.cpp \ src/infowindow.cpp \ src/config/configwindow.cpp \ @@ -52,11 +51,12 @@ SOURCES += src/main.cpp\ src/config/clickablelabel.cpp \ src/config/filenameeditor.cpp \ src/utils/filenamehandler.cpp \ - src/config/strftimechooserwidget.cpp + src/config/strftimechooserwidget.cpp \ + src/capture/tools/capturetool.cpp \ + src/capture/capturebutton.cpp HEADERS += \ src/controller.h \ - src/capture/button.h \ src/capture/buttonhandler.h \ src/infowindow.h \ src/config/configwindow.h \ @@ -71,7 +71,9 @@ HEADERS += \ src/config/clickablelabel.h \ src/config/filenameeditor.h \ src/utils/filenamehandler.h \ - src/config/strftimechooserwidget.h + src/config/strftimechooserwidget.h \ + src/capture/tools/capturetool.h \ + src/capture/capturebutton.h RESOURCES += \ graphics.qrc diff --git a/img/buttonIconsBlack/format-text.png b/img/buttonIconsBlack/format-text.png deleted file mode 100644 index 7c62a4dc56110c87444b5969ea567185c0fba3c1..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 254 zcmeAS@N?(olHy`uVBq!ia0vp^5+KaM1|%Pp+x`GjoCO|{#S9F5he4R}c>anMprB-l zYeY$Kep*R+Vo@qXd3m{BW?pu2a$-TMUVc&f>~}U&Kt2s(PML^ zVk6%Pz3ks0HR|i6EjsUK@Ukv^ wFmd&{%%dCz?K>TRzF(nor{8-v|DTz>ZRR?c1Kchj0XmDp)78&qol`;+0JAq+1ONa4 diff --git a/img/buttonIconsBlack/mouse-off.png b/img/buttonIconsBlack/mouse-off.png deleted file mode 100644 index e52e6bb913f89a47a4ca163b7cd26fdb0c6312e5..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 387 zcmV-}0et?6P)pF8FWQhbW?9;ba!ELWdL_~cP?peYja~^aAhuUa%Y?FJQ@H10T4+< zK~zYI&DA?@!axv!;a^GQV3Z=~h;s{QIT;d=2REQdT3n(u+<@05BGCY)!6`heten_8 z>kTL)SzcSa^LfTE_y>^y&%nYux0G{9Na7fH0Zu?Jn+bD#lsUJ)$y>n8N>l}yZ6<4e z#FaJf04dN0GGOa*L0zElnlzQG`4Hp=cvDtj+VxNe#C*5KM&6Y`4m`Q4h=I=<#09Kf z0KmaoFbD2{Yha=P_8P!cV%lYpKaaB^Rppo4RW+|MphbcJ4H68v5NGTI5Y=P4Q3Aic zj2jIw@&L+6PXjzsd`+7m>KJanMprB-l zYeY$Kep*R+Vo@qXd3m{BW?pu2a$-TMUVc&f>~}U&Kt*>wT^vI^I`2;PyQit$Kd$ne$Nxt~oFLPJ6{K fXW{$X|AJHAr)lNO{@x0pM;Sa_{an^LB{Ts5L$rf) diff --git a/img/buttonIconsWhite/mouse-off.png b/img/buttonIconsWhite/mouse-off.png deleted file mode 100644 index 5774518ffa66dee2cfc7b192c300c3776a206f40..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 394 zcmV;50d@X~P)pF8FWQhbW?9;ba!ELWdL_~cP?peYja~^aAhuUa%Y?FJQ@H10T)R` zK~zYI#nn4b!$1%K&=sH%M=3Z5;TECgWJvtE0R^!q^Ozrx%+|3<2*ur&Y1&em=RsluSmKeFo1mHAPMSanMprB-l zYeY$Kep*R+Vo@qXd3m{BW?pu2a$-TMUVc&f>~}U&Kt&HdT^vI^I`2+B&)Z}m+M=6%`bP$-a=}<8vjUc{9CrLuST;`iXL#|4kly}F@0TulDE#O)gXRS0)ci0e z$q7GLjvtV#P2> zlj4zEE*pwC+1s8ljv3nMWo?O%Ry;_bB z6)pVsIYt|NJ;Cqm-kZsIQLI;Y=10p$4%den7K{@&E>OR@@PCYHuKDd&eizOStXdD$ i=6jvH diff --git a/src/capture/buttonhandler.cpp b/src/capture/buttonhandler.cpp index e63b72d6..9fe31f60 100644 --- a/src/capture/buttonhandler.cpp +++ b/src/capture/buttonhandler.cpp @@ -25,7 +25,7 @@ namespace { const int SEPARATION = 6; } -ButtonHandler::ButtonHandler(const QVector &v, QObject *parent) : +ButtonHandler::ButtonHandler(const QVector &v, QObject *parent) : QObject(parent) { if (!v.isEmpty()) { @@ -40,11 +40,11 @@ ButtonHandler::ButtonHandler(QObject *parent) : } void ButtonHandler::hide() { - for (Button *b: m_vectorButtons) b->hide(); + for (CaptureButton *b: m_vectorButtons) b->hide(); } void ButtonHandler::show() { - for (Button *b: m_vectorButtons) b->animatedShow(); + for (CaptureButton *b: m_vectorButtons) b->animatedShow(); } bool ButtonHandler::isVisible() const { @@ -63,13 +63,13 @@ size_t ButtonHandler::size() const { void ButtonHandler::updatePosition(const QRect &selection, const QRect &limits) { - const QVector::size_type vecLength = m_vectorButtons.size(); + const QVector::size_type vecLength = m_vectorButtons.size(); if (vecLength == 0) { return; } // button dimmensions - const int baseHeight = Button::getButtonBaseSize(); - const int baseWidth = Button::getButtonBaseSize(); + const int baseHeight = CaptureButton::getButtonBaseSize(); + const int baseWidth = CaptureButton::getButtonBaseSize(); // copy of the selection area for internal modifications QRect baseArea = selection; @@ -104,7 +104,7 @@ void ButtonHandler::updatePosition(const QRect &selection, baseArea.setHeight(baseHeight); } // indicates the actual button to be moved - QVector::size_type elemIndicator = 0; + QVector::size_type elemIndicator = 0; while (elemIndicator < vecLength) { // update of blocked sides @@ -263,9 +263,9 @@ QVector ButtonHandler::getHPoints( if (elements % 2 == 0) { shift = m_distance * (elements / 2) - (SEPARATION / 2); } else { - shift = m_distance * ((elements-1) / 2) + Button::getButtonBaseSize() / 2; + shift = m_distance * ((elements-1) / 2) + CaptureButton::getButtonBaseSize() / 2; } - if (!leftToRight) { shift -= Button::getButtonBaseSize(); } + if (!leftToRight) { shift -= CaptureButton::getButtonBaseSize(); } int x = leftToRight ? center.x() - shift : center.x() + shift; QPoint i(x, center.y()); @@ -289,9 +289,9 @@ QVector ButtonHandler::getVPoints( if (elements % 2 == 0) { shift = m_distance * (elements / 2) - (SEPARATION / 2); } else { - shift = m_distance * ((elements-1) / 2) + Button::getButtonBaseSize() / 2; + shift = m_distance * ((elements-1) / 2) + CaptureButton::getButtonBaseSize() / 2; } - if (!upToDown) { shift -= Button::getButtonBaseSize(); } + if (!upToDown) { shift -= CaptureButton::getButtonBaseSize(); } int y = upToDown ? center.y() - shift : center.y() + shift; QPoint i(center.x(), y); @@ -303,8 +303,8 @@ QVector ButtonHandler::getVPoints( return res; } // setButtons redefines the buttons of the button handler -void ButtonHandler::setButtons(const QVector