Fix some issues detected by Clazy (#384)

* Fix old style connect

* Fix unneeded QString memory allocations
This commit is contained in:
Alfredo Ramos
2018-10-23 18:04:42 -05:00
committed by Dharkael
parent 7d91b00072
commit ee2f583acd
48 changed files with 231 additions and 231 deletions

View File

@@ -33,7 +33,7 @@ QString FileNameHandler::parsedPattern() {
QString FileNameHandler::parseFilename(const QString &name) {
QString res = name;
if (name.isEmpty()) {
res = "%F_%H-%M";
res = QLatin1String("%F_%H-%M");
}
std::time_t t = std::time(NULL);
@@ -45,7 +45,7 @@ QString FileNameHandler::parseFilename(const QString &name) {
free(tempData);
// add the parsed pattern in a correct format for the filesystem
res = res.replace("/", "").replace(":", "-");
res = res.replace(QLatin1String("/"), QStringLiteral("")).replace(QLatin1String(":"), QLatin1String("-"));
return res;
}
@@ -87,14 +87,14 @@ char * FileNameHandler::QStringTocharArr(const QString &s) {
void FileNameHandler::fixPath(QString &directory, QString &filename) {
// add '/' at the end of the directory
if (!directory.endsWith("/")) {
directory += "/";
if (!directory.endsWith(QLatin1String("/"))) {
directory += QLatin1String("/");
}
// add numeration in case of repeated filename in the directory
// find unused name adding _n where n is a number
QFileInfo checkFile(directory + filename + ".png");
if (checkFile.exists()) {
filename += "_";
filename += QLatin1String("_");
int i = 1;
while (true) {
checkFile.setFile(