From bf5a9ca154de04c23924a048d161ef108554c40c Mon Sep 17 00:00:00 2001 From: Yuxuan Shui Date: Sat, 28 Nov 2020 19:49:15 +0000 Subject: [PATCH] tests: don't call .check() in set_window_size So we can bundle this request together with other requests, making reproducing time critical bugs easier. Signed-off-by: Yuxuan Shui --- tests/testcases/common.py | 4 ++-- tests/testcases/issue394.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testcases/common.py b/tests/testcases/common.py index 442a90f..8214aff 100644 --- a/tests/testcases/common.py +++ b/tests/testcases/common.py @@ -28,10 +28,10 @@ def set_window_class(conn, wid, name): str_type = to_atom(conn, "STRING") conn.core.ChangePropertyChecked(xproto.PropMode.Replace, wid, prop_name, str_type, 8, len(name), name).check() -def set_window_size(conn, wid, width, height): +def set_window_size_async(conn, wid, width, height): value_mask = xproto.ConfigWindow.Width | xproto.ConfigWindow.Height value_list = [width, height] - conn.core.ConfigureWindowChecked(wid, value_mask, value_list).check() + return conn.core.ConfigureWindowChecked(wid, value_mask, value_list) def find_picom_window(conn): prop_name = to_atom(conn, "WM_NAME") diff --git a/tests/testcases/issue394.py b/tests/testcases/issue394.py index e7cafba..3bc4877 100755 --- a/tests/testcases/issue394.py +++ b/tests/testcases/issue394.py @@ -3,7 +3,7 @@ import xcffib.xproto as xproto import xcffib import time -from common import set_window_name, set_window_size +from common import set_window_name, set_window_size_async conn = xcffib.connect() setup = conn.get_setup() @@ -29,7 +29,7 @@ time.sleep(0.5) # Resize the window and destroy print("resize and destroy") -set_window_size(conn, wid, 150, 150) +set_window_size_async(conn, wid, 150, 150) conn.core.DestroyWindowChecked(wid).check() time.sleep(0.5)