From c3fb9ef017ad6f12081c8f77ccef428f52be2a32 Mon Sep 17 00:00:00 2001 From: Yuxuan Shui Date: Tue, 25 Jan 2022 00:15:08 +0000 Subject: [PATCH] core: don't crash when binding root pixmap failed Fixes #767 Signed-off-by: Yuxuan Shui --- src/picom.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/picom.c b/src/picom.c index 2219b1b..e4a47b8 100644 --- a/src/picom.c +++ b/src/picom.c @@ -898,9 +898,13 @@ void root_damaged(session_t *ps) { if (pixmap != XCB_NONE) { ps->root_image = ps->backend_data->ops->bind_pixmap( ps->backend_data, pixmap, x_get_visual_info(ps->c, ps->vis), false); - ps->backend_data->ops->set_image_property( - ps->backend_data, IMAGE_PROPERTY_EFFECTIVE_SIZE, - ps->root_image, (int[]){ps->root_width, ps->root_height}); + if (ps->root_image) { + ps->backend_data->ops->set_image_property( + ps->backend_data, IMAGE_PROPERTY_EFFECTIVE_SIZE, + ps->root_image, (int[]){ps->root_width, ps->root_height}); + } else { + log_error("Failed to bind root back pixmap"); + } } }