benkyd/scrabble-online
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

good enough

Browse Source
This commit is contained in:
Ben
2021-05-10 22:32:30 +01:00
parent 4da8332992
commit eb3e19cbf1
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
TODO
View File

@@ -59,6 +59,9 @@
→ Should lobbies persist once game starts? → Should lobbies persist once game starts?
☐ Bugfixes ☐ Bugfixes
✔ If a user leaves their current game then makes a new one, it's corrupted @done(21-05-10 17:56) → If a user leaves their current game then makes a new one, it's corrupted
→ If a user disconnects during a game, the game is irrevokably corrupted → If a user disconnects during a game, the game is irrevokably corrupted
→ Usually, if a player leaves, it's fine, but if the host leaves. The lobbby is destructed and the logic creates a new game on the spot and they're the only player → Usually, if a player leaves, it's fine, but if the host leaves. The lobbby is destructed and the logic creates a new game on the spot and they're the only player
→ Sometimes it scores words wrong and it requires a restart
→ Sometimes it recognises words wrong and it requires a restart
→ Sometimes it doesnt pass the turn along and it requires a restart

3
server/src/lobbies.js
View File

@@ -73,8 +73,7 @@ function IsLobbyReady(lobbyuid)
if (!Lobbies[lobbyuid]) return false; if (!Lobbies[lobbyuid]) return false;
// only support 2-4 players // only support 2-4 players
// https://en.wikipedia.org/wiki/Scrabble // https://en.wikipedia.org/wiki/Scrabble
// TODO: URGENT ADD THIS BACK AFTER TESTING if (Lobbies[lobbyuid].players.length <= 1) return false;
// if (Lobbies[lobbyuid].players.length <= 1) return false;
if (Lobbies[lobbyuid].players.length > 4) return false; if (Lobbies[lobbyuid].players.length > 4) return false;
return Lobbies[lobbyuid].players.every(e => e.ready); return Lobbies[lobbyuid].players.every(e => e.ready);