benkyd/tinyobjloader
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cppcheck suggested performance improvement

Browse Source 
variables should be passed by reference.
They are passed by value. It could be passed as a (const) reference which is usually faster and recommended in C++.

This gives a 9% performance boost in my project.
26.28s to load instead of 28.94s
This commit is contained in:
Sean Jones
2013-11-25 20:54:46 +00:00
parent d52efe044f
commit 7afab4ad56
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tiny_obj_loader.cc
View File

@@ -196,12 +196,12 @@ updateVertex(
static bool static bool
exportFaceGroupToShape( exportFaceGroupToShape(
shape_t& shape, shape_t& shape,
const std::vector<float> in_positions, const std::vector<float> &in_positions,
const std::vector<float> in_normals, const std::vector<float> &in_normals,
const std::vector<float> in_texcoords, const std::vector<float> &in_texcoords,
const std::vector<std::vector<vertex_index> >& faceGroup, const std::vector<std::vector<vertex_index> >& faceGroup,
const material_t material, const material_t &material,
const std::string name) const std::string &name)
{ {
if (faceGroup.empty()) { if (faceGroup.empty()) {
return false; return false;