MacOS CI - allow upload build with failed notarization check

(cherry picked from commit ef39c1c24048a645574dd00e84c956f8070c9869)

.github/workflows/MacOS-pack.yml

@@ -40,6 +40,8 @@ jobs:
       APPLE_DEVELOPER_ID_APPLICATION_CERT_PASS: ${{ secrets.APPLE_DEVELOPER_ID_APPLICATION_CERT_PASS }}
       # Any temporary password for keychain, which will be created on github actions CI
       APPLE_TEMP_CI_KEYCHAIN_PASS: ${{ secrets.APPLE_TEMP_CI_KEYCHAIN_PASS }}
+      # Temporary variable for internal use, it will be set on the "Build dmg" step
+      NOTARIZATION_CHECK: false
 
     steps:
       - name: Checkout Source code
@@ -70,13 +72,6 @@ jobs:
           cd "${DIR_PKG}"
           ${HELPERS_SCRIPTS_PATH}/siqn_qtapp.sh flameshot
 
-#          /usr/local/opt/qt5/bin/macdeployqt flameshot.app -dmg
-
-#      - name: Update dmg package links
-#        run: |
-#          cd build/src
-#          ../../packaging/macos/update_package.sh
-
       - name: Upload dmg package
         shell: bash
         run: |
@@ -90,3 +85,13 @@ jobs:
         with:
           name: MacOS-artifact
           path: ${{ github.workspace }}/build/src/flameshot.dmg
+
+      - name: Notarization status
+        shell: bash
+        run: |
+          if [[ "${NOTARIZATION_CHECK}" == "true" ]]; then
+            echo "Notarization check succeed"
+          else
+            echo "::warning Notarization check failed"
+            # exit 1
+          fi

packaging/macos/siqn_qtapp.sh

@@ -70,8 +70,10 @@ do
 done
 
 if [[ "${ATTEMPT}" == 0 ]]; then
-  echo "ERROR: notarization check failed"
-  exit 1
+  export NOTARIZATION_CHECK="false"
+  echo "::warning Notarization check failed"
+else
+  export NOTARIZATION_CHECK="true"
 fi
 
 echo "--> Start verify signing process"